Flyte-core add missing podEnv values #4807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In flyteorg#4756 / fb9ffd5, flyte-core got consistent podEnv values established in values.yaml. However, these values were not properly injected into *all* the containers being used in various deployments. Fix that so that they are used in all deployments Signed-off-by: ddl-ebrown <[email protected]>
- Some linters consider empty env: as invalid k8s YAML, because env is typically an [] when no values are set Prevent rendering the console env block without values Signed-off-by: ddl-ebrown <[email protected]>
dosubot
bot
added
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4807 +/- ##
==========================================
+ Coverage 58.98% 59.12% +0.14%
==========================================
Files 644 644
Lines 55145 52788 -2357
==========================================
- Hits 32527 31213 -1314
+ Misses 20046 19001 -1045
- Partials 2572 2574 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davidmirror-ops
approved these changes
Feb 5, 2024
|
Correct. We have some checks in our deployments that set |
|
@ddl-ebrown for the failing check, you should rebase onto |
pingsutw
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Fix webhook typo, add podLabels, add podEnv to flyte-core Helm chart #4756 / fb9ffd5, flyte-core got
consistent podEnv values established in values.yaml. However, these
values were not properly injected into all the containers being
used in various deployments.
Fix that so that they are used in all deployments
Make sure console doesn't render an empty env: block
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link